linux-kernel - Re: [PATCH v8 08/10] sched: add SD_PREFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5458462F.6000704@gmail.com>
Date:	Tue, 04 Nov 2014 11:21:19 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Vincent Guittot <vincent.guittot@...aro.org>, peterz@...radead.org,
	mingo@...nel.org, linux-kernel@...r.kernel.org,
	preeti@...ux.vnet.ibm.com, Morten.Rasmussen@....com,
	kamalesh@...ux.vnet.ibm.com, linux@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org
CC:	riel@...hat.com, efault@....de, nicolas.pitre@...aro.org,
	linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH v8 08/10] sched: add SD_PREFER_SIBLING for SMT level

Hi Vincent,
On 14/10/31 下午4:47, Vincent Guittot wrote:
> Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that
> the scheduler will put at least 1 task per core.

What's the behavior before this patch?

Regards,
Wanpeng Li

>
> Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> Reviewed-by: Preeti U. Murthy <preeti@...ux.vnet.ibm.com>
> ---
>   kernel/sched/core.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 37fb92c..731f2ad 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6165,6 +6165,7 @@ sd_init(struct sched_domain_topology_level *tl, int cpu)
>   	 */
>   
>   	if (sd->flags & SD_SHARE_CPUCAPACITY) {
> +		sd->flags |= SD_PREFER_SIBLING;
>   		sd->imbalance_pct = 110;
>   		sd->smt_gain = 1178; /* ~15% */
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/