linux-kernel - Re: [PATCH] backlight: extend of_find_backlight_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141104082510.GF17577@x1>
Date:	Tue, 4 Nov 2014 08:25:10 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Jingoo Han <jg1.han@...sung.com>, Bryan Wu <cooloney@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: extend of_find_backlight_by_node stub-check
 to modules

On Tue, 04 Nov 2014, Heiko Stübner wrote:

> Commit de3d75dc2311 ("backlight: Use of_find_backlight_by_node stub when
> backlight class disabled") did not take into account that the backlight
> class can also be compiled as module. Extend the check to prevent
> redefinition warnings when the backlight device class is compiled as module.
> 
> Reported-by: kbuild test robot
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
>  include/linux/backlight.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied with Jingoo's Ack.

> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index d9cb644..92b9817 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -157,7 +157,8 @@ struct generic_bl_info {
>  	void (*kick_battery)(void);
>  };
>  
> -#if defined(CONFIG_OF) && defined(CONFIG_BACKLIGHT_CLASS_DEVICE)
> +#if defined(CONFIG_OF) && (defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> +			   defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
>  struct backlight_device *of_find_backlight_by_node(struct device_node *node);
>  #else
>  static inline struct backlight_device *

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/