linux-kernel - Re: your patch "mm: Remove false WARN_ON from pagecache_isize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141104090814.GA2953@quack.suse.cz>
Date:	Tue, 4 Nov 2014 10:08:14 +0100
From:	Jan Kara <jack@...e.cz>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	Dave Chinner <david@...morbit.com>, xfs@....sgi.com,
	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: your patch "mm: Remove false WARN_ON from
 pagecache_isize_extended()"

On Tue 04-11-14 07:40:20, Jan Beulich wrote:
> >>> On 03.11.14 at 23:18, <david@...morbit.com> wrote:
> > On Mon, Nov 03, 2014 at 04:41:13PM +0000, Jan Beulich wrote:
> >> having run into that warning too, I looked into it a little, and now
> >> having found that patch am pretty uncertain: Both truncate_setsize()
> >> and pagecache_isize_extended() document that they want to be
> >> called with i_mutex held, so removing the WARN_ON() alone seems
> >> either incomplete or wrong. What I found to work without violating
> >> this documented requirement is the patch below.
> > 
> > Or, just perhaps, the comments are wrong....
> 
> Right - that's what I was suggesting with the option of the patch
> being incomplete (rather than just removing the WARN_ON() it
> should also remove the respective comments then).
  Yeah, I'll update the comments to mention there are filesystem which use
serialization different from i_mutex. Thanks for catching this.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/