linux-kernel - Re: [PATCH v1 02/11] backports: extend module_init() module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415095355.2064.9.camel@sipsolutions.net>
Date:	Tue, 04 Nov 2014 11:02:35 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	backports@...r.kernel.org, linux-kernel@...r.kernel.org,
	yann.morin.1998@...e.fr, mmarek@...e.cz, sassmann@...nic.de,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH v1 02/11] backports: extend module_init() module_exit()
 for built-in

On Tue, 2014-11-04 at 00:42 -0800, Luis R. Rodriguez wrote:

> +#ifndef MODULE
> +/*
> + * Forcing the backports module to load allows us to easily
> + * identify the backport.
> + */

That comment is wrong really, making the dependency on the symbol forced
the backport module to load but if it's built-in that makes no sense.

> +#undef module_init
> +#define module_init(fn)							\
> +	static int __init __init_backport_##fn(void)			\
> +	{								\
> +		backport_dependency_symbol();				\

That won't do anything at all after all.

> +		return fn();						\
> +	}								\
> +	__initcall(__init_backport_##fn);
> +
> +#undef module_exit
> +#define module_exit(fn)							\
> +	static void __exit __exit_backport_##fn(void)			\
> +	{								\
> +		fn();							\
> +		rcu_barrier();						\
> +	}								\
> +	__exitcall(__exit_backport_##fn);

This is also pointless if it's built-in.

I don't think this patch makes sense, you just want to add the "#ifdef
MODULE" I guess.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/