linux-kernel - Re: [PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for am437x-evm and am43x-epos-evm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5458B563.7080302@ti.com>
Date:	Tue, 4 Nov 2014 16:45:47 +0530
From:	Vignesh R <vigneshr@...com>
To:	Nishanth Menon <nm@...com>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for
 am437x-evm and am43x-epos-evm



On Friday 31 October 2014 07:16 PM, Nishanth Menon wrote:
> On 13:16-20141031, Vignesh R wrote:
>> This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm.
>>
>> Signed-off-by: Vignesh R <vigneshr@...com>
>> ---
>>  arch/arm/boot/dts/am4372.dtsi        | 20 ++++++++++++++++++++
>>  arch/arm/boot/dts/am437x-gp-evm.dts  |  8 ++++++++
>>  arch/arm/boot/dts/am43x-epos-evm.dts |  8 ++++++++
> 
> I personally prefer the soc dt split off from board dt, but others
> prefer this as done here.. no objections either way.
> 
>>  3 files changed, 36 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index 46660ffd2b65..fd2de8f256e6 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -667,6 +667,26 @@
>>  			};
>>  		};
>>  
>> +		tscadc: tscadc@...0d000 {
>> +			compatible = "ti,am4372-tscadc","ti,am3359-tscadc";
> ^^ bindings ?
> $ git grep ti,am4372-tscadc Documentation/devicetree/bindings/
> 	returns nothing as of 3.18-rc2
> 

I will drop unused ti,am4372-tscadc.

>> +			reg = <0x44e0d000 0x1000>;
>> +			ti,hwmods = "adc_tsc";
>> +			interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&adc_tsc_fck>;
>> +			clock-names = "fck";
>> +			status = "disabled";
>> +
>> +			tsc {
>> +				compatible = "ti,am4372-tsc", "ti,am3359-tsc";
>> +			};
>> +
>> +			adc {
>> +				#io-channel-cells = <1>;
>> +				compatible = "ti,am4372-adc", "ti,am3359-adc";
>> +			};
>> +
>> +		};
>> +
>>  		sham: sham@...00000 {
>>  			compatible = "ti,omap5-sham";
>>  			ti,hwmods = "sham";
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index e7ac47fa6615..2ffd6d6dcc87 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -343,6 +343,14 @@
>>  	status = "okay";
>>  };
>>  
>> +&tscadc {
>> +	status = "okay";
>> +
>> +	adc {
>> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> +	};
>> +};
>> +
>>  &ecap0 {
>>  	status = "okay";
>>  	pinctrl-names = "default";
>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
>> index ac3e4859935f..f9bc607f3b3a 100644
>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
>> @@ -519,6 +519,14 @@
>>  	status = "okay";
>>  };
>>  
>> +&tscadc {
>> +	status = "okay";
>> +
>> +	adc {
>> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> +	};
>> +};
>> +
>>  &ecap0 {
>>  		status = "okay";
>>  		pinctrl-names = "default";
>> -- 
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/