linux-kernel - Re: [PATCH v2] Add ltc3562 voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5458D636.3000401@topic.nl>
Date:	Tue, 4 Nov 2014 14:35:50 +0100
From:	Mike Looijmans <mike.looijmans@...ic.nl>
To:	Mark Brown <broonie@...nel.org>
CC:	<lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Add ltc3562 voltage regulator driver

On 11/04/2014 12:34 PM, Mark Brown wrote:
> On Tue, Nov 04, 2014 at 09:55:14AM +0100, Mike Looijmans wrote:
>> On 11/03/2014 06:38 PM, Mike Looijmans wrote:
>
>>>> You need to develop against current versions of the kernel, this is
>>>> something that was merged into Linus' tree during the merge window.
>
>>> Is this an absolute show-stopper for you?
>
>>> With some effort I could move from our current 3.15 to 3.17, but even that
>>> wouldn't be recent enough then. I can justify spending a few days on getting
>>> the driver integrated into mainline, even if the initial version cost less
>>> than that; but moving everything to mainline is going to take weeks and the
>>> boss is definitely going to say "no" to that.
>
> It should be easy to backport the support into your current kernel, it's
> just a few commits and there hasn't been much development in this area
> of the code.  Can you take a look at doing that please?

I can cherry-pick about 4 commits to get the updated core into my 3.15 tree.

I still need help with one thing that isn't clear to me though. The DT is 
parsed when calling regulator_register. But then how do I fetch my "private" 
settings in there BEFORE the regulator gets enabled? The feedback resistors 
and regulator mode must be set to the correct board before the output is 
enabled, otherwise it may damage the chip and its periferals.

The only two drivers using the regulators_node (tps65217 and isl9305.c) don't 
have any private values in the DT.

M.


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@...ic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/