linux-kernel - Re: [PATCH 3/3] input: stmpe: bias keypad columns properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141104015721.GA21814@dtor-ws>
Date:	Mon, 3 Nov 2014 17:57:21 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 3/3] input: stmpe: bias keypad columns properly

Hi Linus,

On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote:
> +	if (variant->set_pullup) {
> +		u8 val;
> +
> +		ret = stmpe_reg_read(stmpe, pureg);
> +		if (ret)
> +			return ret;
> +
> +		/* Do not touch unused pins, may be used for GPIO */
> +		val = ret & ~pu_pins;
> +		val |= pu_pins;
> +
> +		ret = stmpe_reg_write(stmpe, pureg, val);

Don't we need
		if (ret) {
			dev_err(...);
			return ret;
		}

here?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/