linux-kernel - Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141104001355.GA10900@kroah.com>
Date:	Mon, 3 Nov 2014 16:13:55 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	steph <stephanie.s.wallick@...el.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	"Sean O. Stalley" <sean.stalley@...el.com>
Subject: Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
> On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
> > On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
> > > +EXPORT_SYMBOL(mausb_register_ms_driver);
> > 
> > EXPORT_SYMBOL_GPL()?  I have to ask...
> >
> The source is dual-licenced under BSD and GPL. It was our understanding
> that dual-licensed should use EXPORT_SYMBOL() instead. Is that wrong?

Talk to your company lawyers please to get confirmation of what you want
to do here, I can't answer this question, I just have to ask...

> > > +static int mausb_hcd_init(void)
> > > +{
> > > +	int ret;
> > > +
> > > +	/* register HCD driver */
> > > +	ret = platform_driver_register(&mausb_driver);
> > 
> > Why is this a platform driver?  How does this relate to platform
> > hardware?
> > 
> The driver doesn't require platform resources. It looks like a host
> controller driver but communicates over the network instead of to
> a physical host controller. There is no MA USB-specific hardware.
> 
> Should we use a struct device instead of a struct platform_device?

Yes, please make it a "virtual" device.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/