lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Nov 2014 15:12:10 -0500 (EST) From: David Miller <davem@...emloft.net> To: fabf@...net.be Cc: linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org Subject: Re: [PATCH 1/1 net-next] ipv4: ip_frag_queue function clean-up From: Fabian Frederick <fabf@...net.be> Date: Tue, 4 Nov 2014 20:41:37 +0100 > -remove unnecessary else after break > -declare free_it sk_buff * only once (like prev and next) > > Signed-off-by: Fabian Frederick <fabf@...net.be> I disagree. Declaring a local variable in it's inner-most scope is preferable to moving it to the top level and making the job of the compiler and the code auditor more difficult. I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists