linux-kernel - Re: [PATCH 0/4 v3] fs: Remove i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrX4ZZcokwMGP6SQbSG5+3vZ8K3ZVU9ZX6Kjj1qdTqr_8w@mail.gmail.com>
Date:	Tue, 4 Nov 2014 12:25:47 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 0/4 v3] fs: Remove i_devices from struct inode

On Tue, Nov 4, 2014 at 12:20 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Tue, Nov 04, 2014 at 12:14:26PM -0800, Andy Lutomirski wrote:
>
>> Yeah, this idea clearly doesn't work.  But I wonder whether the
>> revised variant (which may be just moving cd_forget and bd_forget from
>> evict to iput_final) would work.
>
> How the hell is it better?  Neither of those will happen as long as dentry
> is retained.  And with /dev on tmpfs (which is bloody common) _that_ won't
> happen until device node is unlinked...

It's by my misunderstanding of how inode refcounting works.  The idea
would be to drop the cdev reference when there are no non-VFS-internal
references to the inode left.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/