linux-kernel - Re: [PATCH v3 2/3] perf: Userspace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878ujqw3v4.fsf@sejong.aot.lge.com>
Date:	Wed, 05 Nov 2014 15:36:31 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Peter Zijlstra 
	<public-peterz-wEGCiKHe2LqWVfeAwA7xHQ@...ne.gmane.org>
Cc:	Pawel Moll <public-pawel.moll-5wv7dgnIgG8@...ne.gmane.org>,
	Namhyung Kim 
	<public-namhyung-DgEjT+Ai2ygdnm+yROfE0A@...ne.gmane.org>,
	Richard Cochran 
	<public-richardcochran-Re5JQEeQqe8AvxtiuMwx3w@...ne.gmane.org>,
	Steven Rostedt 
	<public-rostedt-nx8X9YLhiw1AfugRpC6u6w@...ne.gmane.org>,
	Ingo Molnar <public-mingo-H+wXaHxf7aLQT0dZR+AlfA@...ne.gmane.org>,
	Paul Mackerras 
	<public-paulus-eUNUBHrolfbYtjvyW6yDsg@...ne.gmane.org>,
	Arnaldo Carvalho de Melo 
	<public-acme-DgEjT+Ai2ygdnm+yROfE0A@...ne.gmane.org>,
	John Stultz 
	<public-john.stultz-QSEj5FYQhm4dnm+yROfE0A@...ne.gmane.org>,
	Masami Hiramatsu 
	<public-masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@...ne.gmane.org>,
	Christopher Covington 
	<public-cov-sgV2jX0FEOL9JmXXK+q4OQ@...ne.gmane.org>,
	David Ahern 
	<public-dsahern-Re5JQEeQqe8AvxtiuMwx3w@...ne.gmane.org>,
	Thomas Gleixner 
	<public-tglx-hfZtesqFncYOwBW4kG4KsQ@...ne.gmane.org>,
	Tomeu Vizoso 
	<public-tomeu-XCtybt49RKsYaV1qd6yewg@...ne.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org" 
	<public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org>,
	"linux-api-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org" 
	<public-linux-api-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org>
Subject: Re: [PATCH v3 2/3] perf: Userspace event



Hi Peter and Pawel,

On Tue, 4 Nov 2014 19:40:31 +0100, Peter Zijlstra wrote:
> On Tue, Nov 04, 2014 at 04:42:11PM +0000, Pawel Moll wrote:
>> 
>> 1. I'm wrong and the record doesn't have to be padded to make it 8 bytes
>> aligned. Then I can drop the additional size field.
>
> No, you're right, we're supposed to stay 8 byte aligned.
>
>> 2. I could impose a limitation on the prctl API that the data size must
>> be 8 bytes aligned. Bad idea in my opinion, I'd rather not.
>
> Agreed.
>
>> 3. The additional size (for the data part) field stays. Notice that
>> PERF_SAMPLE_RAW has it as well :-)
>
> Right, with binary data there is no other day. With \0 terminated
> strings there won't be a problem, but I think we decided we wanted to
> allow any binary blow.

Ah, I missed that.  Thank you guys for explanation.

Thanks,
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/