linux-kernel - Re: [RFC PATCH] virtio-mmio: support for multiple irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5459EA0E.8020309@huawei.com>
Date:	Wed, 5 Nov 2014 17:12:46 +0800
From:	Shannon Zhao <zhaoshenglong@...wei.com>
To:	GAUGUEY Rémy 228890 <remy.gauguey@....fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"mst@...hat.com" <mst@...hat.com>,
	"peter.maydell@...aro.org" <peter.maydell@...aro.org>,
	"john.liuli@...wei.com" <john.liuli@...wei.com>,
	"joel.schopp@....com" <joel.schopp@....com>,
	"qemu-devel@...gnu.org" <qemu-devel@...gnu.org>,
	"n.nikolaev@...tualopensystems.com" 
	<n.nikolaev@...tualopensystems.com>,
	"virtualization@...ts.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>,
	"peter.huangpeng@...wei.com" <peter.huangpeng@...wei.com>,
	"hangaohuai@...wei.com" <hangaohuai@...wei.com>
Subject: Re: [RFC PATCH] virtio-mmio: support for multiple irqs

Hi Rémy,

On 2014/11/5 16:26, GAUGUEY Rémy 228890 wrote:
> Hi Shannon, 
> 
>> Type of backend         bandwith(GBytes/sec)
>> virtio-net              0.66
>> vhost-net               1.49
>> vhost-net with irqfd    2.01
>>
>> Test cmd: ./iperf -c 192.168.0.2 -P 1 -i 10 -p 5001 -f G -t 60
> 
> Impressive results !
> Could you please detail your setup ? which platform are you using and which GbE controller ?

Sorry for not telling the test scenario. This test scenario is from Host to Guest. It just
compare the performance of different backends. I did this test on ARM64 platform.

The setup was based on:
1)on host kvm-arm should support ioeventfd and irqfd
	The irqfd patch is from Eric "ARM: KVM: add irqfd support".
	http://www.spinics.net/lists/kvm-arm/msg11014.html

	The ioeventfd patch is reworked by me from Antonios.
	http://www.spinics.net/lists/kvm-arm/msg08413.html

2)qemu should enable ioeventfd support for virtio-mmio
	This patch is refer to Ying-Shiuan Pan and reworked for new qemu branch.
	https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg00594.html

3)qemu should enable multiple irqs for virtio-mmio
	This patch isn't sent to qemu maillist as we want to check whether this is the right direction.
	If you want to test, I'll send it to you.

4)in guest should enable support virtio-mmio to request multiple irqs
	This is what this patch do.

> As a reference, it would be good also to have result with an iperf to the HOST to see how far we are from a native configuration...
Agree!
> 
> Also, I assume a pending Qemu patch is necessary to assign multiple irqs ? I'm correct ? 
Yes, the patch is on it's way :)
> 
> Thanks a lot, 
> Best regards
> Rémy
> 
> -----Message d'origine-----
> De : Shannon Zhao [mailto:zhaoshenglong@...wei.com] 
> Envoyé : mercredi 5 novembre 2014 09:00
> À : linux-kernel@...r.kernel.org
> Cc : mst@...hat.com; peter.maydell@...aro.org; john.liuli@...wei.com; joel.schopp@....com; GAUGUEY Rémy 228890; qemu-devel@...gnu.org; n.nikolaev@...tualopensystems.com; virtualization@...ts.linux-foundation.org; peter.huangpeng@...wei.com; hangaohuai@...wei.com
> Objet : Re: [RFC PATCH] virtio-mmio: support for multiple irqs
> 
> 
> On 2014/11/4 17:35, Shannon Zhao wrote:
>> As the current virtio-mmio only support single irq, so some advanced 
>> features such as vhost-net with irqfd are not supported. And the net 
>> performance is not the best without vhost-net and irqfd supporting.
>>
> Hi Joel, Peter, Mst,
> 
> Some virtio-net with virtio-mmio performance data on ARM added as followed:
> 
> Type of backend         bandwith(GBytes/sec)
> virtio-net              0.66
> vhost-net               1.49
> vhost-net with irqfd    2.01
> 
> Test cmd: ./iperf -c 192.168.0.2 -P 1 -i 10 -p 5001 -f G -t 60
> 
>>>From this test data, irqfd has great improvement (about 30%) on performance.
> So maybe it's necessary to enable multiple irq support to make vhost-net with virtio-mmio on ARM be able to use irqfd.
> 
> How do you guys think? Look forward for your feedback.
> 
> Thanks,
> Shannon
> 
>> This patch support virtio-mmio to request multiple irqs like 
>> virtio-pci. With this patch and qemu assigning multiple irqs for 
>> virtio-mmio device, it's ok to use vhost-net with irqfd on arm/arm64.
>>
> .
> 

-- 
Shannon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/