linux-kernel - Re: [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success from error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5459EFF7.6070405@redhat.com>
Date:	Wed, 05 Nov 2014 10:37:59 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	"Chen, Tiejun" <tiejun.chen@...el.com>,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success
 from error



On 05/11/2014 02:43, Chen, Tiejun wrote:
>>
>> +        default:
>> +            WARN_ON(1);
>> +            continue;
> 
> 'continue' versus 'break'?

Yes, it avoids falling through to "vmcs12_write_any(&vmx->vcpu, field,
field_value)".

> Looks we're missing another place, 

Right, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/