linux-kernel - Re: [PATCH] acct: eliminate compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141105143754.GR7996@ZenIV.linux.org.uk>
Date:	Wed, 5 Nov 2014 14:37:54 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ying Xue <ying.xue@...driver.com>, linux-kernel@...r.kernel.org,
	jack@...e.cz
Subject: Re: [PATCH] acct: eliminate compile warning

On Tue, Aug 26, 2014 at 04:25:01PM -0700, Andrew Morton wrote:

> We could actually do
> 
> 	if (ACCT_VERSION == 3)
> 		...
> 
> in lots of places in acct.c.  The code would be less ugly and
> compilation coverage testing would improve.

... too much.  Finally got around to trying that; the problem is that
you can't do that in structure declarations.  acct_t is either struct
acct, or struct acct_v3, and while we could split fill_ac() into
v3 and v1/v2 versions, it still doesn't sort everything out.  So it
looks like that idea is no-go ;-/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/