linux-kernel - Re: [PATCH v5 7/7] tpm: create TPM 2.0 devices using own device class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141105174836.GA5296@obsidianresearch.com>
Date:	Wed, 5 Nov 2014 10:48:36 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	Peter Huewe <peterhuewe@....de>, Ashley Lai <ashley@...leylai.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	josh.triplett@...el.com, christophe.ricard@...il.com,
	jason.gunthorpe@...idianresearch.com
Subject: Re: [PATCH v5 7/7] tpm: create TPM 2.0 devices using own device class

On Wed, Nov 05, 2014 at 09:40:29AM +0200, Jarkko Sakkinen wrote:

> > I mean, if we have a patch that does:
> > 
> > struct tpm_chip {
> >    struct device cdev;  // the class device
> >    struct device *pdev; // the 'platform' device chip is bound too
> > 
> >    struct device *dev = pdev; // Temporary Compatability
> > [+ device_register/etc/etc]
> > 
> > Then both cdev and pdev should always be valid. We should not have cdev
> > be valid for TPM2 and invalid for TPM1, that is just a big mess.

> As a first patch I'll do a patch that does dev -> pdev rename and
> nothing else. IMHO it's clean and easy to review if no other changes
> are contained. One reason for this is obviously that I want to use
> cdev for struct cdev not for the class device.

Well, once you add cdev, pdev and dev, you want most uses of dev to
become cdev and some uses to become pdev.

Just bulk renaming dev -> pdev and then bulk renaming pdev -> cdev
seems like lots of churn...

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/