[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1415210053.12884.11.camel@smoke>
Date: Wed, 05 Nov 2014 09:54:13 -0800
From: Geoff Levand <geoff@...radead.org>
To: JBottomley@...allels.com
Cc: Michael Ellerman <mpe@...erman.id.au>,
linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] [SCSI] ps3rom: fix error return code
On Wed, 2014-11-05 at 21:11 +1100, Michael Ellerman wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
>
> Set the return variable to an error code as done elsewhere in the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---
> drivers/scsi/ps3rom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index ef23fabe3924..619caf1acc9c 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev)
> if (!host) {
> dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
> __func__, __LINE__);
> + error = -ENOMEM;
> goto fail_teardown;
> }
>
Looks OK. James, please apply.
Acked-By: Geoff Levand <geoff@...radead.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists