linux-kernel - Re: [PATCH V7 13/17] perf, x86: enable LBR callstack when recording callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141105175205.GP3274@tassilo.jf.intel.com>
Date:	Wed, 5 Nov 2014 09:52:05 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	"Liang, Kan" <kan.liang@...el.com>,
	Stephane Eranian <eranian@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH V7 13/17] perf, x86: enable LBR callstack when recording
 callchain

On Wed, Nov 05, 2014 at 05:29:32PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 05, 2014 at 03:53:34PM +0000, Liang, Kan wrote:
> > > I don't think it would be very hard to modify the patch set to make that 3rd
> > > mode visible. Just need to make that new PERF_RECORD_* type visible to
> > > user and modify the compatibility checks.
> > 
> > It's not hard. But LBR is not an independent callchain options. It's better to be
> > a supplement of FP. Otherwise, it may confuse the user. He enables the
> > BRANCH_CALL_STACK, but the data is partly or even not at all from hardware.
> 
> What the user sees is up to userspace. It should not be forced by the
> kernel/user interface.

The original idea was to abstract it inside the kernel. Unlike dwarf the
LBR callstack is simple enough that it can be easily abstracted. If you don't
want to do that yes then handling it in the user tools is the right way.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/