linux-kernel - Re: [RFC][PATCH 10/12 v3] seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141105153355.22167d0a@gandalf.local.home>
Date:	Wed, 5 Nov 2014 15:33:55 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Kosina <jkosina@...e.cz>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH 10/12 v3] seq-buf: Make seq_buf_bprintf()
 conditional on CONFIG_BINARY_PRINTF

On Wed, 5 Nov 2014 18:06:05 +0100
Petr Mladek <pmladek@...e.cz> wrote:

> On Tue 2014-11-04 10:52:47, Steven Rostedt wrote:
> > From: "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>
> > 
> > The function bstr_printf() from lib/vsprnintf.c is only available if
> > CONFIG_BINARY_PRINTF is defined. This is due to the only user currently
> > being the tracing infrastructure, which needs to select this config
> > when tracing is configured. Until there is another user of the binary
> > printf formats, this will continue to be the case.
> > 
> > Since seq_buf.c is now lives in lib/ and is compiled even without
> > tracing, it must encompass its use of bstr_printf() which is used
> > by seq_buf_printf(). This too is only used by the tracing infrastructure
> > and is still encapsulated by the CONFIG_BINARY_PRINTF.
> > 
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Please switch the order and do this change before moving to lib/.
> IMHO, the current order would break bisecting when tracing is
> disabled.

I agree. I was being lazy and when my test broke, I added the update to
test again. But to move this change to before the move, I need to
monkey with the patch file.

I'll move it before the move regardless.

> 
> Otherwise, the change looks good in itself, so:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.cz>

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/