| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20141105130018.7750139c497f842bdf6070e4@linux-foundation.org> Date: Wed, 5 Nov 2014 13:00:18 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Benjamin LaHaise <bcrl@...ck.org> Cc: Gu Zheng <guz.fnst@...fujitsu.com>, linux-aio@...ck.org, m.koenigshaus@....de, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise <bcrl@...ck.org> wrote: > On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: > > ping... > > I need someone a bit more familiar with this area of code to chime in on > reviewing this. Andrew, can you provide any feedback on this fix? That looks like a sensible solution and the changelog is good. A couple of suggested modifications: - Don't use the term "pinned" in the changelog without explaining it - it's a terribly ambiguous term. I assume here you mean "pinned by elevating the page's refcount"? - Could we have just one wee little code comment, explaining why aio_fs_backing_dev_info exists, what function it is serving? Put yourself in the position of a reader wondering "why is this here". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists