linux-kernel - Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 06 Nov 2014 07:42:09 +0800
From:	Ian Kent <raven@...maw.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	autofs mailing list <autofs@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

On Wed, 2014-11-05 at 15:20 -0800, Joe Perches wrote:
> 
> > But idea of using pr_xxx() and pr_fmt() (actually that's too open to
> > name clashes so it would need to be named something like autofs_pr_fmt()
> > anyway) looks like it results in less readable code so I'd really prefer
> > not to do that.
> 
> Using pr_info/pr_debug (or any other pr_<level>) is a
> generic mechanism in the kernel.  Adding a
> #define pr_fmt is also generic thing that works with
> all the pr_<level> uses in a specific compilation unit.

LOL, so you recommend I look more closely, I will.
In the meantime I'll send the other patches to Andrew.

Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/