linux-kernel - Re: [PATCH] lib/flex_array: make build optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141106215056.GK26472@redhat.com>
Date:	Thu, 6 Nov 2014 16:50:56 -0500
From:	Aristeu Rozanski <aris@...hat.com>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, Changli Gao <xiaosuo@...il.com>,
	David Rientjes <rientjes@...gle.com>,
	Eric Paris <eparis@...hat.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Jesse Gross <jesse@...ira.com>,
	Jonathan Corbet <corbet@....net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Pravin Shelar <pshelar@...ira.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH] lib/flex_array: make build optional

On Thu, Nov 06, 2014 at 01:44:54PM -0800, Dave Hansen wrote:
> On 11/06/2014 01:33 PM, Dave Hansen wrote:
> > On 11/06/2014 01:27 PM, Aristeu Rozanski wrote:
> >> +config FLEX_ARRAY
> >> +	bool "Flexible array"
> >> +	default n
> >> +	help
> >> +	  This option enables an implementation of flexible arrays which
> >> +	  allows creating arrays of fixed size elements with an arbritrary
> >> +	  size without requiring the single allocation of a contiguous area.
> >> +
> >> +	  See Documentation/flexible-arrays.txt
> > 
> > Is there any reason to expose this to the user via Kconfig?
> > 
> > No sane person would even turn it on if they don't need it.
> 
> IOW, I think you should just make it:
> 
> config FLEX_ARRAY
> 	def_bool n

Joe Pershes complained on a similar patch on making it default to 'n'.
Will rework the patches this way.

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/