linux-kernel - Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141106045819.GB6272@saruman>
Date:	Wed, 5 Nov 2014 22:58:19 -0600
From:	Felipe Balbi <balbi@...com>
To:	Kiran Raparthy <kiran.kumar@...aro.org>
CC:	Felipe Balbi <balbi@...com>, LKML <linux-kernel@...r.kernel.org>,
	Todd Poynor <toddpoynor@...gle.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Arve Hj�nnev�g <arve@...roid.com>,
	Benoit Goby <benoit@...roid.com>
Subject: Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in
 peripheral mode

On Thu, Nov 06, 2014 at 10:04:01AM +0530, Kiran Raparthy wrote:
> Hi Felipe,
> 
> On 6 November 2014 01:10, Felipe Balbi <balbi@...com> wrote:
> > On Tue, Nov 04, 2014 at 03:30:54PM +0530, Kiran Kumar Raparthy wrote:
> >> From: Todd Poynor <toddpoynor@...gle.com>
> >>
> >> usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode
> >>
> >> Some systems require a mechanism to prevent system to enter into suspend
> >> state when USB is connected and enumerated in peripheral mode.
> >>
> >> This patch provides an interface to hold a wakeupsource to prevent suspend.
> >> PHY drivers can use this interface when USB is connected and enumerated in
> >> peripheral mode.
> >>
> >> A timed wakeupsource is temporarily held on USB disconnect events, to allow
> >> the rest of the system to react to the USB disconnection (dropping host
> >> sessions, updating charger status, etc.) prior to re-allowing suspend.
> >>
> >> Cc: Kishon Vijay Abraham I <kishon@...com>
> >> Cc: Felipe Balbi <balbi@...com>
> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> Cc: linux-kernel@...r.kernel.org
> >> Cc: linux-usb@...r.kernel.org
> >> Cc: Android Kernel Team <kernel-team@...roid.com>
> >> Cc: John Stultz <john.stultz@...aro.org>
> >> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> >> Cc: Arve Hjønnevåg <arve@...roid.com>
> >> Cc: Benoit Goby <benoit@...roid.com>
> >> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> >> [kiran: Added context to commit message, squished build fixes
> >> from Benoit Goby and Arve Hjønnevåg, changed wakelocks usage
> >> to wakeupsource, merged Todd's refactoring logic and simplified
> >> the structures and code and addressed community feedback]
> >> Signed-off-by: Kiran Raparthy <kiran.kumar@...aro.org>
> >
> > you still didn't get this right. I asked that you introduce
> > usb_phy_set_event() as a separate patch, then make PHY drivers use it
> > and only on a third patch should you hold a wakeupsource.
> Thanks for your time.
> Sure,I'll resend the patches as per your suggestion,could you please
> let me know whether you are okay with this new approach?.
> This will help me to consolidate all your inputs in new patch set.

I'll review again in the morning, sure.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)