linux-kernel - Re: [PATCH 4/6] trace: Replace seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415234867.6634.42.camel@perches.com>
Date:	Wed, 05 Nov 2014 16:47:47 -0800
From:	Joe Perches <joe@...ches.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

On Wed, 2014-11-05 at 19:38 -0500, Steven Rostedt wrote:
> On Wed, 05 Nov 2014 14:51:48 -0800 Joe Perches <joe@...ches.com> wrote:

[]
> > > I know that it's considered bad form
> > > to split strings like this, but I consider this one of the exceptions
> > > to the rule.
> > 
> > Why is that?
> > 
> > btw: when the strings fragments are put on the same line,
> > it's nicer to take out the intermediate joining " " bits too.
> > 
> > I'd've probably used 2 seq_puts calls like:
> > 
> > 	seq_puts(m, "  Function                               Hit    Time            Avg             s^2\n");
> > 	seq_puts(m, "  --------                               ---    ----            ---             ---\n");
> > 
> 
> In this case it's just that I hate that big white space followed by
> content.
> 
> Maybe I'll change my mind in the future, but for now, I'd rather just
> leave it as is.

My eyes generally skip over the embedded whitespace.

It's also generally less code space to use a single format string
instead of something like:

	printf("  %-39s%-7s%-16s%-16s%s\n", "Function", "Hit", "Time", "Avg", "s^2");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/