linux-kernel - Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141106121143.GW8509@sirena.org.uk>
Date:	Thu, 6 Nov 2014 12:11:43 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Paul Moore <paul@...l-moore.com>
Cc:	Chen Gang <gang.chen.5i5j@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>, eparis@...hat.com,
	linux-audit@...hat.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from
 !AUDIT area to !AUDITSYSCALL area

On Wed, Nov 05, 2014 at 12:43:01PM -0800, Paul Moore wrote:
> On Tuesday, November 04, 2014 11:09:52 PM Chen Gang wrote:
> > audit_file() is related with AUDITSYSCALL, not related with AUDIT, so
> > need move dummy one from !AUDIT area to !AUDITSYSCALL area. Or it will
> > cause issue if CONFIG_AUDIT with !CONFIG_AUDITSYSCALL.

> > The related error (with allmodconfig under tile):

> >     CC      fs/open.o
> >   fs/open.c: In function 'SYSC_fchmod':
> >   fs/open.c:530:3: error: implicit declaration of function 'audit_file'
> > [-Werror=implicit-function-declaration] audit_file(f.file);
> >      ^

> What version of the kernel source are you looking at?  I don't see the 
> audit_file() function anywhere ...

This issue has been breaking ARMv8 defconfig builds in -next for a few
days now.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)