linux-kernel - Re: [alsa-devel] [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <545B773E.3020103@metafoo.de>
Date:	Thu, 06 Nov 2014 14:27:26 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Peter Rosin <peda@...ator.liu.se>, alsa-devel@...a-project.org
CC:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Peter Rosin <peda@...ntia.se>, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors
 TFA9879 amplifier.

On 11/06/2014 01:54 PM, Peter Rosin wrote:
[...]
> +#define TFA9879_REG(codec, reg, field, value)				\
> +	snd_soc_update_bits(codec, TFA9879_ ## reg,			\
> +			    TFA9879_ ## field ## _MASK,			\
> +			    (value) << TFA9879_ ## field ## _SHIFT)
> +

I'm not sure I like this macro. Just using snd_soc_update_bits should make 
it easier to review the patch since people understand its sematnics.

[...]
> +static int tfa9879_probe(struct snd_soc_codec *codec)
> +{
> +	struct tfa9879_priv *tfa9879 = snd_soc_codec_get_drvdata(codec);
> +
> +	codec->control_data = tfa9879->regmap;

This is no longer necessary and won't even build with the latest ASoC tree.

> +
> +	return 0;
> +}
> +
[...]
> +static struct snd_soc_dai_ops tfa9879_dai_ops = {

const

> +	.prepare = tfa9879_prepare,
> +	.hw_params = tfa9879_hw_params,
> +	.shutdown = tfa9879_shutdown,
> +	.digital_mute = tfa9879_digital_mute,
> +	.set_fmt = tfa9879_set_fmt,
> +};
[...]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/