| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Nov 2014 07:58:28 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: "Winkler, Tomas" <tomas.winkler@...el.com> Cc: "arnd@...db.de" <arnd@...db.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [char-misc-next V3] mei: add reference counting for me clients On Thu, Nov 06, 2014 at 08:40:21AM +0000, Winkler, Tomas wrote: > > > > On Tue, Nov 04, 2014 at 05:22:51AM +0000, Winkler, Tomas wrote: > > > > > > > > On Mon, Nov 03, 2014 at 10:42:05AM +0200, Tomas Winkler wrote: > > > > > To support dynamic addition/remove we add reference > > > > > counter. > > > > > > > > What is keeping two different threads / cpus from grabbing a reference > > > > at the same time the other one is dropping it? > > > > > > > > You have a list here, with no locking, right? You also don't have any > > > > locking for your kref, which isn't good at all... > > > > > > > > Please audit and fix up. > > > > > > Of course there is a lock, it wouldn't work at all. It is not explicit > > > but we run under device_lock mutex. > > > > Please make it explicit :) > > Not sure what you mean by that? There is a lot of options in this laconic sentence. In looking at that patch, it was not obvious to me that any locking was happening at all, so that needs to be addressed somehow before I can accept the change. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists