linux-kernel - Re: [PATCH] goldfish: fixed sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141106001240.GA2440@kroah.com>
Date:	Wed, 5 Nov 2014 16:12:40 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	alan@...ux.intel.com
Subject: Re: [PATCH] goldfish: fixed sparse warning

On Fri, Oct 10, 2014 at 07:28:45PM +0530, Sudip Mukherjee wrote:
> fixed sparse warning of Using plain integer as NULL pointer
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/tty/goldfish.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
> index 09495f5..c24b963 100644
> --- a/drivers/tty/goldfish.c
> +++ b/drivers/tty/goldfish.c
> @@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
>  {
>  	if ((unsigned)co->index > goldfish_tty_line_count)
>  		return -ENODEV;
> -	if (goldfish_ttys[co->index].base == 0)
> +	if (!goldfish_ttys[co->index].base)
>  		return -ENODEV;
>  	return 0;
>  }
> @@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
>  	unregister_console(&qtty->console);
>  	tty_unregister_device(goldfish_tty_driver, pdev->id);
>  	iounmap(qtty->base);
> -	qtty->base = 0;
> +	qtty->base = NULL;
>  	free_irq(qtty->irq, pdev);
>  	goldfish_tty_current_line_count--;
>  	if (goldfish_tty_current_line_count == 0)
> -- 
> 1.8.1.2

Sorry, but someone else sent this same patch before you did :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/