linux-kernel - Re: [PATCH V6 03/18] x86: Use new cache mode type in drivers/video/fbdev/gbefb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Nov 2014 10:16:45 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Juergen Gross <jgross@...e.com>
CC:	<hpa@...or.com>, <x86@...nel.org>, <tglx@...utronix.de>,
	<mingo@...hat.com>, <stefan.bader@...onical.com>,
	<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xensource.com>,
	<konrad.wilk@...cle.com>, <ville.syrjala@...ux.intel.com>,
	<david.vrabel@...rix.com>, <jbeulich@...e.com>,
	<toshi.kani@...com>, <plagnioj@...osoft.com>, <bhelgaas@...gle.com>
Subject: Re: [PATCH V6 03/18] x86: Use new cache mode type in drivers/video/fbdev/gbefb.c

On 03/11/14 15:01, Juergen Gross wrote:
> Instead of directly using the cache mode bits in the pte switch to
> using the cache mode type.
> 
> Based-on-patch-by: Stefan Bader <stefan.bader@...onical.com>
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  drivers/video/fbdev/gbefb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 4aa56ba..6d9ef39 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -54,7 +54,8 @@ struct gbefb_par {
>  #endif
>  #endif
>  #ifdef CONFIG_X86
> -#define pgprot_fb(_prot) ((_prot) | _PAGE_PCD)
> +#define pgprot_fb(_prot) (((_prot) & ~_PAGE_CACHE_MASK) |	\
> +			  cachemode2protval(_PAGE_CACHE_MODE_UC_MINUS))
>  #endif
>  
>  /*
> 

For this and vermilion fb:

Acked-by: Tomi Valkeinen <tomi.valkeinen@...com>

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)