linux-kernel - RE: [Xen-devel] [PATCH] xen/arm: Return correct code error for xen_swiotlb_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B944B469BF5302468AC6EB05E56CC70D17DF04@lhreml509-mbb>
Date:	Fri, 7 Nov 2014 09:56:36 +0000
From:	Frediano Ziglio <frediano.ziglio@...wei.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Frediano Ziglio <freddy77@...il.com>
CC:	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Xen-devel] [PATCH] xen/arm: Return correct code error for
 xen_swiotlb_map_page

> On Thu, 6 Nov 2014, Frediano Ziglio wrote:
> > 2014-11-06 17:30 GMT+00:00 Stefano Stabellini
> <stefano.stabellini@...citrix.com>:
> >       On Thu, 6 Nov 2014, Frediano Ziglio wrote:
> >       > On ARM error code is not 0 so avoid to return it as error.
> >       >
> >       > Signed-off-by: Frediano Ziglio <frediano.ziglio@...wei.com>
> >
> >       Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> >
> >
> >       Could you please fix the same error in lib/swiotlb.c too please?
> >
> >
> > Same patch or another ?
> >
> 
> Another
> 

lib/swiotlb.c is not affected at a physical address to io_tlb_overflow_buffer is returned in case of error.
Looks like a way to transform silently an allocation error to a more serious memory corruption.

Frediano

> >
> >       >  drivers/xen/swiotlb-xen.c | 2 +-
> >       >  1 file changed, 1 insertion(+), 1 deletion(-)
> >       >
> >       > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-
> xen.c
> >       > index ebd8f21..3b8d628 100644
> >       > --- a/drivers/xen/swiotlb-xen.c
> >       > +++ b/drivers/xen/swiotlb-xen.c
> >       > @@ -425,7 +425,7 @@ dma_addr_t xen_swiotlb_map_page(struct
> device *dev, struct page *page,
> >       >        */
> >       >       if (!dma_capable(dev, dev_addr, size)) {
> >       >               swiotlb_tbl_unmap_single(dev, map, size, dir);
> >       > -             dev_addr = 0;
> >       > +             dev_addr = DMA_ERROR_CODE;
> >       >       }
> >       >       return dev_addr;
> >       >  }
> >       > --
> >       > 1.9.1
> >       >
> >       >
> >       > --
> >       > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> >       > the body of a message to majordomo@...r.kernel.org
> >       > More majordomo info at  http://vger.kernel.org/majordomo-
> info.html
> >       > Please read the FAQ at http://secure-
> web.cisco.com/1cvjROyUxV6SnA0uBTMRubqrQWsaXGhps-
> FWjY3vly9AxaKKlt2DPY7GjL0FCHeP4rsbjKsc-P4zH2_7-kpcxwEH-udGrGCCq
> >       kCLlH1-fLOo1X6Nlui6EwEVHUpB2r7gt-
> Gsgxbep9QWPnIdypDPNf8Hf5clxCMXYcvWsOK5s3qg/http%3A%2F%2Fwww.tux.org%2Fl
> kml%2F
> >       >
> >
> >       _______________________________________________
> >       Xen-devel mailing list
> >       Xen-devel@...ts.xen.org
> >       http://lists.xen.org/xen-devel
> >
> >
> >
> >