linux-kernel - Re: [PATCH 1/2] UBI: Implement UBI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcvp5Eugd79bLV7e8kOL_Lhut1KeYYu5eZby9kQUee0j5sJqQ@mail.gmail.com>
Date:	Fri, 7 Nov 2014 12:42:06 +0000
From:	Andrew Murray <amurray@...edded-bits.co.uk>
To:	Richard Weinberger <richard@....at>
Cc:	Artem Bityutskiy <dedekind1@...il.com>,
	linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Subject: Re: [PATCH 1/2] UBI: Implement UBI_METAONLY

On 29 October 2014 20:20, Richard Weinberger <richard@....at> wrote:
> Am 29.10.2014 um 21:11 schrieb Andrew Murray:
>> On 29 October 2014 14:52, Richard Weinberger <richard@....at> wrote:
>>> diff --git a/include/linux/mtd/ubi.h b/include/linux/mtd/ubi.h
>>> index c3918a0..82b693f 100644
>>> --- a/include/linux/mtd/ubi.h
>>> +++ b/include/linux/mtd/ubi.h
>>> @@ -34,11 +34,13 @@
>>>   * UBI_READONLY: read-only mode
>>>   * UBI_READWRITE: read-write mode
>>>   * UBI_EXCLUSIVE: exclusive mode
>>> + * UBI_METAONLY: modify voulme meta data only
>>
>> Typo - s/voulme/volume/g
>
> Thanks. :)
>
>>>   */
>>>  enum {
>>>         UBI_READONLY = 1,
>>>         UBI_READWRITE,
>>> -       UBI_EXCLUSIVE
>>> +       UBI_EXCLUSIVE,
>>> +       UBI_METAONLY
>>>  };
>>>
>>
>> Also you may want to add something similar to this:
>>
>> --- a/drivers/mtd/ubi/ubi.h
>> +++ b/drivers/mtd/ubi/ubi.h
>> @@ -339,7 +339,7 @@ struct ubi_volume {
>>  /**
>>   * struct ubi_volume_desc - UBI volume descriptor returned when it is opened.
>>   * @vol: reference to the corresponding volume description object
>> - * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, or %UBI_EXCLUSIVE)
>> + * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, %UBI_EXCLUSIVE or
>> %UBI_METAONLY)
>>   */
>>  struct ubi_volume_desc {
>>         struct ubi_volume *vol;
>>
>> There is also a similar mention in gluebi.c: 'readers/writes/exclusive'.
>
> Please send a patch for that. :)

Apologies for the delay - did you just want junk a hunk so you can
include in your next revision - or did you want me to come up with a
v2 of your patch?

Andrew Murray

>
> Thanks,
> //richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/