linux-kernel - Re: [Xen-devel] [PATCH V2 2/5] xen: Delay m2p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <545CD26E.8040404@citrix.com>
Date:	Fri, 7 Nov 2014 14:08:46 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Juergen Gross <jgross@...e.com>,
	David Vrabel <david.vrabel@...rix.com>,
	<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xensource.com>,
	<konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>,
	<x86@...nel.org>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>
Subject: Re: [Xen-devel] [PATCH V2 2/5] xen: Delay m2p_override initialization

On 07/11/14 13:19, Juergen Gross wrote:
> On 11/07/2014 02:04 PM, David Vrabel wrote:
>>
>> I suppose this is the "make some functions static" but it's an
>> unreviewable mess.  If you can't do this with some one line changes
>> adding "static" and perhaps some forward declarations then please drop
>> this bit.
> 
> Do you really prefer forward declarations instead of pure code movement?
> I can do as you request, but just want to make sure.

Normally I prefer not having forward declarations...  How about a patch
that does this and then a 2nd patch that does the pure code motion.
Maybe that will produce a better diff?

You can also try the --patience option for git diff (etc.).  This may
produce more readable diffs.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/