linux-kernel - Re: [PATCH v5 2/5] regulator: Add function to map modes to struct regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141107155400.GU8509@sirena.org.uk>
Date:	Fri, 7 Nov 2014 15:54:00 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Olof Johansson <olof@...om.net>,
	Chris Zhong <zyw@...k-chips.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Abhilash Kesavan <kesavan.abhilash@...il.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/5] regulator: Add function to map modes to struct
 regulator_desc

On Fri, Nov 07, 2014 at 02:00:02PM +0100, Javier Martinez Canillas wrote:

> + * @map_modes: Callback invoked to translate from hardware to standard modes.
> + *             The function returns the standard REGULATOR_MODE that maps to
> + *             the hardware specific mode passed as an argument.

of_map_mode - it's only one mode and this is mapping to/from DT.

> + *             If the callback is not defined, the "regulator-initial-mode"
> + *             and suspend states "regulator-mode" properties won't be parsed.

Just remove this, it's pretty obvious at best and going to bit rot at
worst.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)