linux-kernel - Re: [PATCH] arm64: kernel: Copy register_persistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 7 Nov 2014 16:38:36 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Anatol Pomozov <anatol.pomozov@...il.com>
Cc:	Stephen Warren <swarren@...dia.com>,
	Marc Zyngier <Marc.Zyngier@....com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64
 source subtree

On Fri, Nov 07, 2014 at 04:24:19PM +0000, Anatol Pomozov wrote:
> Hi
> 
> On Fri, Nov 7, 2014 at 2:40 AM, Mark Rutland <mark.rutland@....com> wrote:
> > On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
> >> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> >> > +Stephen
> >> >
> >> > This patch is for tegra20_timer that uses register_persistent_clock().
> >> > I did not find any way to share the same arch code for arm/arm64.
> >> >
> >> > Actually this register_persistent_clock() does not look arm specific
> >> > at all. Would it be better to move it somewhere outside of arch/?
> >>
> >> No CC to linux-tegra@ or the other Tegra maintainers?
> >>
> >> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
> >> the same code into multiple places.
> >
> > Agreed. This looks in no way architecture specific, and having this in
> > common code would be preferable to copying.
> 
> Where the code common for arm and arm64 should go?
> drivers/???/arm_timekeeping.c ?

I'd argue that this is in no way specific to ARM, and the current weak
functions live in kernel/time/timekeeping.c, so this should too.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/