linux-kernel - Re: PATCH: Fix coding style warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141108165211.GA17400@kroah.com>
Date:	Sat, 8 Nov 2014 08:52:11 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	sharon <sharon.dvir1@...l.huji.ac.il>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: PATCH: Fix coding style warning.

On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote:
> Fix coding style warning.

What coding style warning?  Be specific please.

And your subject:, you aren't saying where in the kernel you are fixing
anything, look at other patches for this file in git, what did the
subject look like for them?

> (First submission, sorry in advance for any dumb stuff I'm missing.
> Let me know and I'll fix it.)

These two sentances don't need to be here :)

> Signed-off-by: Sharon Dvir <sharon.dvir1@...l.huji.ac.il>

This doesn't match up with what the From: line above says, so please fix
the from: line.

> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/android/binder.c
> index c69c40d..655c3bf 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -1267,8 +1267,8 @@ static void
> binder_transaction_buffer_release(struct binder_proc *proc,
>  		switch (fp->type) {
>  		case BINDER_TYPE_BINDER:
>  		case BINDER_TYPE_WEAK_BINDER: {
> -			struct binder_node *node = binder_get_node(proc, fp->binder);
> -
> +			struct binder_node *node = binder_get_node(proc,
> +								fp->binder);
>  			if (node == NULL) {
>  				pr_err("transaction release %d bad node %016llx\n",
>  				       debug_id, (u64)fp->binder);

What tree did you make this against?  This file isn't in linux-next
anymore, is it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/