linux-kernel - Re: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141108203658.GA40319@dtor-ws>
Date:	Sat, 8 Nov 2014 12:36:58 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	NeilBrown <neilb@...e.de>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	GTA04 owners <gta04-owner@...delico.com>
Subject: Re: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is
 recorded.

On Sat, Nov 08, 2014 at 10:40:15AM +1100, NeilBrown wrote:
> 
> 
> This button is treated as a wakeup source, so we need to initialise it
> correctly.
> 
> Without the device_init_wakeup() call, dev->power.wakeup will
> be NULL, and pm_wakeup_event() will do nothing.
> 
> Signed-off-by: NeilBrown <neilb@...e.de>

Applied, thank you.

> 
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index fb3b63b2f85c..8400a1a34d87 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
>  	}
>  
>  	platform_set_drvdata(pdev, pwr);
> +	device_init_wakeup(&pdev->dev, true);
>  
>  	return 0;
>  }



-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/