linux-kernel - Re: [PATCH] rtl8188eu: Remove unnecessary braces for simple return in xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415481824.23530.35.camel@perches.com>
Date:	Sat, 08 Nov 2014 13:23:44 -0800
From:	Joe Perches <joe@...ches.com>
To:	Krzysztof Konopko <kris@...agma.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	navin patidar <navin.patidar@...il.com>,
	Larry Finger <Larry.Finger@...inger.net>, trivial@...nel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8188eu: Remove unnecessary braces for simple return
 in xmit_linux.c

On Sat, 2014-11-08 at 22:14 +0100, Krzysztof Konopko wrote:
> scripts/checkpatch.pl reports a coding style problem in xmit_linux.c
[]
> diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
[]
> @@ -67,9 +67,8 @@ uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen)
>  int rtw_endofpktfile(struct pkt_file *pfile)
>  {
>  
> -	if (pfile->pkt_len == 0) {
> +	if (pfile->pkt_len == 0)
>  		return true;
> -	}
>  
> 
>  	return false;

This should probably be

bool rtw_endofpktfile(const struct pkt_file *pfile_
{
	return !pfile->pkt_len;
}

or just removed altogether and tested directly
in the one place it's used.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/