linux-kernel - Re: [PATCH] PM / Hibernate: Migrate to ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2442680.y0UEcXlDY6@vostro.rjw.lan>
Date:	Sat, 08 Nov 2014 02:47:29 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Arnd Bergmann <arnd@...db.de>,
	Tina Ruchandani <ruchandani.tina@...il.com>
Cc:	pavel@....cz, len.brown@...el.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, opw-kernel@...glegroups.com
Subject: Re: [PATCH] PM / Hibernate: Migrate to ktime_t

On Thursday, October 30, 2014 08:08:17 PM Arnd Bergmann wrote:
> On Thursday 30 October 2014 11:04:53 Tina Ruchandani wrote:
> > This patch migrates swsusp_show_speed and its callers to using ktime_t instead
> > of 'struct timeval' which suffers from the y2038 problem.
> > 
> > Changes to swsusp_show_speed:
> >         - use ktime_t for start and stop times
> >         - pass start and stop times by value
> > Calling functions affected:
> >         - load_image
> >         - load_image_lzo
> >         - save_image
> >         - save_image_lzo
> >         - hibernate_preallocate_memory
> > Design decisions:
> >         - use ktime_t to preserve same granularity of reporting as before
> >         - use centisecs logic as before to avoid 'div by zero' issues caused by
> >           using seconds and nanoseconds directly
> >         - use monotonic time (ktime_get()) since we only care about elapsed time.
> > 
> > Signed-off-by: Tina Ruchandani <ruchandani.tina@...il.com>
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Patch queued up for 3.19-rc1, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/