linux-kernel - Re: [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141108092242.GB2722@sirena.org.uk>
Date:	Sat, 8 Nov 2014 09:22:42 +0000
From:	Mark Brown <broonie@...nel.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	GTA04 owners <gta04-owner@...delico.com>,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change
 requested.

On Sat, Nov 08, 2014 at 11:38:03AM +1100, NeilBrown wrote:

> +	int val = ucontrol->value.integer.value[0];
> +
> +	if (!!(twl4030_read(codec, TWL4030_REG_CODEC_MODE)
> +	       & TWL4030_OPTION_1) == !!val)
> +		/* No change */
> +		return 0;

We shouldn't be accepting attempts to set out of range values so there
should be no need for the !! on val (which confused me when I was
reading this).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)