linux-kernel - Re: [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141108092756.GD2722@sirena.org.uk>
Date:	Sat, 8 Nov 2014 09:27:56 +0000
From:	Mark Brown <broonie@...nel.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	GTA04 owners <gta04-owner@...delico.com>,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice'
 interface.

On Sat, Nov 08, 2014 at 11:38:03AM +1100, NeilBrown wrote:

> -		twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
> -				 TWL4030_VIF_TRI_EN,
> -				 TWL4030_REG_VOICE_IF);
> +		/* These pins only relevant when voice_fmt set */
> +		snd_soc_dapm_disable_pin(&codec->dapm, "VOICEIN");
> +		snd_soc_dapm_disable_pin(&codec->dapm, "VOICEOUT");

Given your previous patch are these trying to control a digital link by
any chance?  If they are they should be removed, and in any case this
sort of thing looks like a machine driver issue.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)