linux-kernel - Re: sound: enable sound support on n900 on devicetree-based boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141109123753.GO2722@sirena.org.uk>
Date:	Sun, 9 Nov 2014 12:37:53 +0000
From:	Mark Brown <broonie@...ian.org>
To:	Pavel Machek <pavel@....cz>
Cc:	pali.rohar@...il.com, sre@...ian.org, sre@...g0.de,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
	aaro.koskinen@....fi, freemangordon@....bg, peter.ujfalusi@...com,
	perex@...ex.cz, tiwai@...e.de, alsa-devel@...a-project.org
Subject: Re: sound: enable sound support on n900 on devicetree-based boot

On Sun, Nov 09, 2014 at 01:02:22PM +0100, Pavel Machek wrote:
> 
> With device tree, it is possible (and encouraged) to build N900
> kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable
> the driver build in this case.

Please do try to use subject lines reflecting the style for the
subsystem.

>  config SND_OMAP_SOC_RX51
>  	tristate "SoC Audio support for Nokia RX-51"
> -	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
> +	depends on SND_OMAP_SOC && ARM && I2C

Please also update the config text so users have a chance to figure out
that this driver is the one they need for their system - I guess most
people won't know what RX-51 is.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)