linux-kernel - Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141109223221.GA3698@titan.lakedaemon.net>
Date:	Sun, 9 Nov 2014 17:32:21 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Niklas Svensson <nks@...wful.org>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	eric.rost@...abylon.net, gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging: skein: fixed sparse warnings related to
 static declarations

On Sun, Nov 09, 2014 at 07:51:36PM +0100, Niklas Svensson wrote:
> 
> On 11/08/2014 08:56 PM, Jason Cooper wrote:
> > On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote:
> >> drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static?
> >> drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static?
> >> drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static?
> >>
> >> Signed-off-by: Niklas Svensson <nks@...wful.org>
> >> ---
> >>  drivers/staging/skein/skein_generic.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> > What tree/tag is this patch against?  There've been quite a few changes
> > to the api this time around.
> >
> linux-next,
> tag: next-20141106
> 
> also applicable for gregkg's staging-next tree

Perfect.

Acked-by: Jason Cooper <jason@...edaemon.net>

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/