lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Nov 2014 10:04:57 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Guenter Roeck <linux@...ck-us.net> Cc: Neelesh Gupta <neelegup@...ux.vnet.ibm.com>, jdelvare@...e.de, benh@....ibm.com, linux-kernel@...r.kernel.org, michaele@....ibm.com, linuxppc-dev@...ts.ozlabs.org, lm-sensors@...sensors.org Subject: Re: [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote: > On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote: > > The current driver probe() function assumes the sensor device to be > > alwary present and gets executed every time if the driver is loaded, > > but the appropriate hardware could not be present. > > > > So, move the platform device creation as part of platform init code > > and use the 'id_table' to check if the device present or not. > > > > Signed-off-by: Neelesh Gupta <neelegup@...ux.vnet.ibm.com> > > Looks good. We'll need an ack from one of the powerpc maintainers to proceed. Looks OK to me. Acked-by: Michael Ellerman <mpe@...erman.id.au> cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists