linux-kernel - Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Nov 2014 15:54:53 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Marc Dietrich <Marc.Dietrich@...physik.uni-giessen.de>,
	devel@...verdev.osuosl.org
CC:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off
 handler

On 11/09/2014 01:41 PM, Marc Dietrich wrote:
> Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck:
>> Register with kernel power-off handler instead of setting pm_power_off
>> directly. Register with default priority since we don't know any better.
>>
>> Cc: Julian Andres Klode <jak@...-linux.org>
>> Cc: Marc Dietrich <marvin24@....de>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net
>
> ok, this version (V5) actually switches the device off in contrast to the
> first implementation. Somehow I have to find out why it works at all without
> irqs.
>
> Acked-by: Marc Dietrich <mavin24@....de>
>

Hi Marc,

The most recent version does not turn off interrupts as long as the
infrastructure (architecture code, ie machine_power_off) doesn't
turn it off.

Thanks a lot for (re-)testing.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/