linux-kernel - Re: [PATCH] lib: mpi: Use "static inline" instead of "extern inline" in header file for __GNUC_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415524261.23530.37.camel@perches.com>
Date:	Sun, 09 Nov 2014 01:11:01 -0800
From:	Joe Perches <joe@...ches.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	dmitry.kasatkin@...el.com,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: mpi: Use "static inline" instead of "extern
 inline" in header file for __GNUC__

On Sun, 2014-11-09 at 16:58 +0800, Chen Gang wrote:
> In header file, "extern inline" may cause multiple definition, so need
> change it to "static inline". And also need be quoted  by __GNUC__ for
> they are as inline functions only for __GNUC__.
[]
> diff --git a/lib/mpi/mpi-inline.h b/lib/mpi/mpi-inline.h
[]
> @@ -30,7 +30,7 @@
>  #define G10_MPI_INLINE_H
>  
>  #ifndef G10_MPI_INLINE_DECL
> -#define G10_MPI_INLINE_DECL  extern inline
> +#define G10_MPI_INLINE_DECL  static inline

Why not remove the #define and use static inline
in the 4 places the #define is currently used?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/