lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 09 Nov 2014 18:49:44 +0800 From: Chen Gang <gang.chen.5i5j@...il.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> CC: linux-input@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "cmetcalf@...era.com" <cmetcalf@...era.com> Subject: Re: [PATCH] drivers: input: mouse: Use "static inline" instead of "inline" in "lifebook.h" After this patch, our tile can pass allmodconfig building. :-) Thanks. On 11/09/2014 06:46 PM, Chen Gang wrote: > For inline function in header file, better to be "static inline", or may > cause building break under the latest upstream gcc (although, probably, > it should be the gcc's issue). > > The related error (with allmodconfig under tile): > > MODPOST 4002 modules > ERROR: "lifebook_detect" [drivers/input/mouse/psmouse.ko] undefined! > > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com> > --- > drivers/input/mouse/lifebook.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/mouse/lifebook.h b/drivers/input/mouse/lifebook.h > index 4c4326c..0baf02a 100644 > --- a/drivers/input/mouse/lifebook.h > +++ b/drivers/input/mouse/lifebook.h > @@ -16,14 +16,14 @@ void lifebook_module_init(void); > int lifebook_detect(struct psmouse *psmouse, bool set_properties); > int lifebook_init(struct psmouse *psmouse); > #else > -inline void lifebook_module_init(void) > +static inline void lifebook_module_init(void) > { > } > -inline int lifebook_detect(struct psmouse *psmouse, bool set_properties) > +static inline int lifebook_detect(struct psmouse *psmouse, bool set_properties) > { > return -ENOSYS; > } > -inline int lifebook_init(struct psmouse *psmouse) > +static inline int lifebook_init(struct psmouse *psmouse) > { > return -ENOSYS; > } > -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists