linux-kernel - Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

Open Source and information security mailing list archives

Message-ID: <20141110122722.34b27c4c@notabene.brown>
Date:	Mon, 10 Nov 2014 12:27:22 +1100
From:	NeilBrown <neilb@...e.de>
To:	"Dr. H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	List for communicating with real GTA04 owners 
	<gta04-owner@...delico.com>
Subject: Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible =
 "ti, twl4030-power" again.

On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
<hns@...delico.com> wrote:

> 
> Am 08.11.2014 um 01:22 schrieb NeilBrown <neilb@...e.de>:
> 
> > 
> > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> >    mfd: twl4030-power: Add generic reset configuration
> > 
> > claims:
> >    Let's add device tree support and configure things for warm reset
> >    as the default when compatible = "ti,twl4030-power".
> > and
> >    Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> > 
> > However the current driver fails to probe with that 'compatible'
> > setting.
> > Restore the old default.
> 
> I think this is a duplicate to 
> 
> 599a1ca80d1d8269d54fdc4abdec8e65141381fe
> 
> (in linux-next)

Ahh, so it is.  Thanks.

NeilBrown

> 
> > 
> > Signed-off-by: NeilBrown <neilb@...e.de>
> > 
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 4d3ff3771491..1a7794f6be15 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> > 
> > static struct of_device_id twl4030_power_of_match[] = {
> > 	{
> > +		.compatible = "ti,twl4030-power",
> > +		.data = NULL,
> > +	},
> > +	{
> > 		.compatible = "ti,twl4030-power-reset",
> > 		.data = &omap3_reset,
> > 	},
> > _______________________________________________
> > Gta04-owner mailing list
> > Gta04-owner@...delico.com
> > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

Content of type "application/pgp-signature" skipped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives