lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Nov 2014 07:45:33 +0100
From:	Jean Delvare <jdelvare@...e.de>
To:	Devin Ryles <devin.ryles@...el.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>, Jonathan Corbet <corbet@....net>,
	james.d.ralston@...el.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, frank.riegel@...el.com
Subject: Re: [PATCH 1/3] SMBUS: Add DeviceIDs for SunrisePoint LP

Hi Devin,

On Fri, 07 Nov 2014 17:55:43 -0500, Devin Ryles wrote:
> From 8386c61977dce52fcdfe7fb279692606f47650bc Mon Sep 17 00:00:00 2001
> From: Devin Ryles <devin.ryles@...el.com>
> Date: Wed, 5 Nov 2014 16:30:03 -0500
> Subject: [PATCH 1/3] SMBUS: Add DeviceIDs for SunrisePoint LP
> 
> This patch adds the DeviceIDs for SunrisePoint LP
> 
> Signed-off-by: Devin Ryles <devin.ryles@...el.com>
> ---
>  Documentation/i2c/busses/i2c-i801 | 1 +
>  drivers/i2c/busses/Kconfig        | 1 +
>  drivers/i2c/busses/i2c-i801.c     | 3 +++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/i2c/busses/i2c-i801email-clients.txt
> b/Documentation/i2c/busses/i2c-i801
> index 793c83d..82f48f7 100644
> --- a/Documentation/i2c/busses/i2c-i801
> +++ b/Documentation/i2c/busses/i2c-i801
> @@ -29,6 +29,7 @@ Supported adapters:
>    * Intel Wildcat Point-LP (PCH)
>    * Intel BayTrail (SOC)
>    * Intel Sunrise Point-H (PCH)
> +  * Intel Sunrise Point-LP (PCH)
>     Datasheets: Publicly available at the Intel website
>  
>  On Intel Patsburg and later chipsets, both the normal host SMBus
> controller
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 917c358..06e99eb 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -123,6 +123,7 @@ config I2C_I801
>  	    Wildcat Point-LP (PCH)
>  	    BayTrail (SOC)
>  	    Sunrise Point-H (PCH)
> +	    Sunrise Point-LP (PCH)
>  
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called i2c-i801.
> diff --git a/drivers/i2c/busses/i2c-i801.c
> b/drivers/i2c/busses/i2c-i801.c
> index 7cfc183..e158e18 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -63,6 +63,7 @@
>   * Wildcat Point-LP (PCH)	0x9ca2	32	hard	yes	yes	yes
>   * BayTrail (SOC)		0x0f12	32	hard	yes	yes	yes
>   * Sunrise Point-H (PCH) 	0xa123  32	hard	yes	yes	yes
> + * Sunrise Point-LP (PCH)	0x9d23	32	hard	yes	yes	yes
>   *
>   * Features supported by this driver:
>   * Software PEC				no
> @@ -186,6 +187,7 @@
>  #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_SMBUS		0x9c22
>  #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS	0x9ca2
>  #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS	0xa123
> +#define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS	0x9d23
>  
>  struct i801_mux_config {
>  	char *gpio_chip;
> @@ -833,6 +835,7 @@ static const struct pci_device_id i801_ids[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
>  	{ 0, }
>  };
>  

This looks good, however your e-mail client wrapped long lines so the
patch can't be applied. Please reconfigure your client to not do that
and send the patches again. In Evolution, you can select the entire
contents of the patch and set the formatting to "Pre-formatted", that
should work. See Documentation/email-clients.txt for more details. If
you're not sure, try sending the message to yourself once first to make
sure the formatting is good.

Thanks,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists