lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Nov 2014 16:37:58 +0900 From: Changman Lee <cm224.lee@...sung.com> To: Jaegeuk Kim <jaegeuk@...nel.org> Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 4/5] f2fs: write node pages if checkpoint is not doing On Sat, Nov 08, 2014 at 11:36:08PM -0800, Jaegeuk Kim wrote: > It needs to write node pages if checkpoint is not doing in order to avoid > memory pressure. > > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org> > --- > fs/f2fs/node.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 4ea2c47..6f514fb 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1314,10 +1314,12 @@ static int f2fs_write_node_page(struct page *page, > return 0; > } > > - if (wbc->for_reclaim) > - goto redirty_out; > - > - down_read(&sbi->node_write); > + if (wbc->for_reclaim) { > + if (!down_read_trylock(&sbi->node_write)) > + goto redirty_out; Previously, we skipped write_page for reclaim path, but from now on, we will write out node page to reclaim memory at any time except checkpoint. We should remember it may occur to break merging bio. Got it. Reviewed-by: Changman Lee <cm224.lee@...sung.com> > + } else { > + down_read(&sbi->node_write); > + } > set_page_writeback(page); > write_node_page(sbi, page, &fio, nid, ni.blk_addr, &new_addr); > set_node_addr(sbi, &ni, new_addr, is_fsync_dnode(page)); > -- > 2.1.1 > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@...ts.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists