linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: implement -o dirsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20141110074712.GD14659@lcm>
Date:	Mon, 10 Nov 2014 16:47:12 +0900
From:	Changman Lee <cm224.lee@...sung.com>
To:	Jaegeuk Kim <jaegeuk@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: implement -o dirsync

On Sun, Nov 09, 2014 at 10:24:22PM -0800, Jaegeuk Kim wrote:
> If a mount option has dirsync, we should call checkpoint for all the directory
> operations.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/namei.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 6312dd2..db3ee09 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -138,6 +138,9 @@ static int f2fs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
>  	stat_inc_inline_inode(inode);
>  	d_instantiate(dentry, inode);
>  	unlock_new_inode(inode);
> +
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  out:
>  	handle_failed_inode(inode);
> @@ -164,6 +167,9 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,
>  	f2fs_unlock_op(sbi);
>  
>  	d_instantiate(dentry, inode);
> +
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  out:
>  	clear_inode_flag(F2FS_I(inode), FI_INC_LINK);
> @@ -233,6 +239,9 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
>  	f2fs_delete_entry(de, page, dir, inode);
>  	f2fs_unlock_op(sbi);
>  
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
> +
>  	/* In order to evict this inode, we set it dirty */
>  	mark_inode_dirty(inode);

Let's move it below mark_inode_dirty.
After sync, it's unnecessary inserting inode into dirty_list.


>  fail:
> @@ -268,6 +277,9 @@ static int f2fs_symlink(struct inode *dir, struct dentry *dentry,
>  
>  	d_instantiate(dentry, inode);
>  	unlock_new_inode(inode);
> +
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return err;
>  out:
>  	handle_failed_inode(inode);
> @@ -304,6 +316,8 @@ static int f2fs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
>  	d_instantiate(dentry, inode);
>  	unlock_new_inode(inode);
>  
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  
>  out_fail:
> @@ -346,8 +360,12 @@ static int f2fs_mknod(struct inode *dir, struct dentry *dentry,
>  	f2fs_unlock_op(sbi);
>  
>  	alloc_nid_done(sbi, inode->i_ino);
> +
>  	d_instantiate(dentry, inode);
>  	unlock_new_inode(inode);
> +
> +	if (IS_DIRSYNC(dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  out:
>  	handle_failed_inode(inode);
> @@ -461,6 +479,9 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry,
>  	}
>  
>  	f2fs_unlock_op(sbi);
> +
> +	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  
>  put_out_dir:
> @@ -600,6 +621,9 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
>  	update_inode_page(new_dir);
>  
>  	f2fs_unlock_op(sbi);
> +
> +	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
> +		f2fs_sync_fs(sbi->sb, 1);
>  	return 0;
>  out_undo:
>  	/* Still we may fail to recover name info of f2fs_inode here */
> -- 
> 2.1.1
> 
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/