linux-kernel - Re: [PATCH v4 3/4] ASoC: simple-card: add multi-CODECs in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Nov 2014 10:04:54 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/4] ASoC: simple-card: add multi-CODECs in DT

On Monday 10 November 2014 10:05:26 Jean-Francois Moine wrote:
> On Mon, 10 Nov 2014 09:39:57 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > On Sunday 09 November 2014 12:22:21 Jean-Francois Moine wrote:
> > > -- sound-dai                            : phandle and port of CPU/CODEC
> > > +either
> > > +  - sound-dai                          : phandle and port of CPU/CODEC
> > > +or
> > > +  - sound-dais                         : list of phandle and port of CODECs
> > 
> > Is it really necessary to change the property name here? I woudl think
> > that you can make it all work more consistently with just the existing
> > 'sound-dai' property, just extend it to allow multiple codecs
> 
> This was an idea from Benoit Cousson:
> 
>  "Something like that:
> 
>    sound-dais = <&spdif_codec 1>, <&hdmi 0>;
> 
>  That being said, it will require changing the name with a plural form,"
> 
> As I coded it, both names are accepted for a single or many codecs.

I don't see a strong reason for coming up with a plural form. If you really
have to, then please list the old form as a deprecated alias and make the
document talk about "sound-dais" as the preferred form independent of the
number of arguments.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/